Design comparison
SolutionDesign
Solution retrospective
i would be glad to hear your feedback :)
Community feedback
- @strikes7Posted 10 months ago
the page looks nice. A little advice, it's not necesary put the input inside the label element when you use the for attribute of the label and the div is not necesary because the label element can have text. , so the code would look like :
<label for="my-input">Text</label> <input id="my-input">
instead of:
<label for="my-input"> <input id="my-input"> <div>Text</div> </label>it looks cleaner and it's easier to style due to having less elements,. i personaly in a case like the one in the challenge just remove the input from the flow with position: absolute due to it's checked state can be manipulated with the label.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord