Interactive rate

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted over 1 year ago

  Hey there! 👋 Here is some feedback to further improve your code:

  • It is best practice ✅ to have separate files for you coding files (HTML, CSS, JS). It helps keep things organized and make it easier to maintain.

  • The section and header element is being used incorrectly ⚠️ and not needed for this challenge.

  • The “icons/illustrations” in this component are purely decorative. ⚠️ Their alt tag should be left blank to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Your form is lacking 😢 a visually hidden legend for accessibility and a fieldset to improve semantics.

  More Info: 📚

  MDN: Legend Element

  MDN: Field Set Element

  • NEVER ❌⚠️⚠️ do this as it creates accessibility issues for users and it is outdated, instead download a px to rem/ em converter in your code editor.

  html {
    font-size: 62.5%;
  }
  

  More Info:📚

  Should I change the default HTML font-size to 62.5%?

  If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  Happy Coding! 👾

  Marked as helpful

  0

  ---

  

  Tian•410

  @TianYeCalPosted over 1 year ago

  @vcarames Thank you! it's so helpful for me, thanks for the help! I'll look up of all these advices!

  0