Submitted over 1 year ago

Interactive rate component, fully responsive and interactive :)!

Joel Leon• 100

@iJoel23

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Interactive rating component

HTML
CSS
JS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

Hi everyone! I hope you can review this solution.

I'm feeling very confident with this one, to be honest, I'm starting again with JavaScript and it's been quite a journey 🤯

I just have a question, is there a better way to add vertical spacing without using flex or grid? Because when I use flex to center all the elements, sometimes I feel like I'm losing control when I'm working with text, I hope you know what I mean. If you have any article about that would be very helpful.

Best regards 🤓

Community feedback

Abdul Khaliq 🚀• 72,660

@0xabdulkhaliq

Posted over 1 year ago

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

I have other recommendations regarding your code that I believe will be of great interest to you.

DECORATIVE SVG'S ♨️:

The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

Since these images do not convey any important information or functionality, there is no need for an alt attribute.

So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

Example:

<img src="images/decorative.svg" alt="">

<img class="card__img-edit" src="img/icon-star.svg" alt="Star">
👇
<img class="card__img-edit" src="img/icon-star.svg" alt="">

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

Joel Leon• 100

@iJoel23

Posted over 1 year ago

@0xAbdulKhalid Thanks a lot! I'll keep that in mind :)!

Steve• 1,170

@peanutbutterjlly

Posted over 1 year ago

I do prefer the ease of using flex/grid to align things vertically but you can tweak it some more if you like by adjusting the line-height of text.

line-height

good luck on your journey 🙏

Joel Leon• 100

@iJoel23

Posted over 1 year ago

@peanutbutterjlly Thanks a lot! I'll implement that for the next one 🤓

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord