Interactive Pricing Component with Styled Components and Typescript

Community feedback

• 

  Prabhash Ranjan•2,540

  @besttlookkPosted over 2 years ago

  hi, Below are some points i like to make:

  1. You design is too small for large screen.Its not even full-screen.
  2. For toggle add some transition. Change is too abrupt.

  I have also done this challenge and for me too most challenging part was slider. I somehow implemented it but mine has some but. I will look into your implementation as its looks like working fine.

  You are using styled-component yet you doing styling the traditional-way (by adding classname ). Is there any particular reason. I recently started using styled-component so i dont know much about it but for style i make component.

  Do let me know. Also here is my implementation for this challenge. https://fem-interactive-pricing-component-silk.vercel.app/

  I would loveto have your feedback.

  Good luck, #happyCoding

  Marked as helpful

  1

  ---

  

  selehadin cyber•90

  @selehadin-cyberPosted over 2 years ago

  @besttlookk thanks a lot for the feedback. i was not coding with big screen in mind. my screen is 1366px wide so it looks normal on my screen. but i might have to adjust that for wide screens. i also need to make it responsive. i was in a bit of a hurry to publish this since i overstepped my self imposed deadline by a half day almost

  0

  

  selehadin cyber•90

  @selehadin-cyberPosted over 2 years ago

  @besttlookk this was the second time i used styled components. and so far i have found out that using styled components doesn't alleviate the need to have a css file .specially for global styling, it is just easier to style the body with a css file than using styled components library. that being said there are some applications where using styled components for global styling makes sense. like implementing dark mode for example

  0