P
Srijan Manandhar• 450
@srijanss
Posted
Your solution looks nice and I like the way you've used different react components for the cards. However, you can make your app more accessible to all the users.
- You can make use of semantic HTML tags like
<article>
for cards,<figure>
and<figcaption>
for image,<button>
tag instead of<a>
as this is submit button for form. web.dev's Welcom to learn A11y is very helpful regarding the accessiblity and its importance - I tried accessing the app using keyboard and only button was accessible using keyboard. You can use radio buttons for the rating items which will make it accessible using keyboard on all the browsers.
- Your solution looks good on desktop. But it overflows on mobile devices.
- Your code is well structured , readable and reusable.
- Solution is almost similar to design, except some hover states of buttons and rating items.
1