Interactive component challenge using HTML, CSS, JS

Community feedback

• 

  Danilo Blas•6,300

  @Sdann26Posted over 2 years ago

  Hi Damilola!

  You have done a very good project, personally I would recommend that you never center with margins as it can cause problems especially if you do not have a fixed height.

  For example I would center in this challenge giving the following attributes to the body:

  display: flex;
  flex-direction: column;
  justify-content: center;
  align-items: center;
  min-height: 100vh; 
  

  I recommend you to give the buttons transitions with the following attribute transition: background 200ms, so the color change is not so abrupt.

  The functionality is ok but try to avoid through JS that if you don't get the value of one of the div you can't execute the submit button.

  Personally I solved the challenge using buttons, there are other people who did it with input-radio but it is preferable to use before using only div.

  Without anything else to add since in the report there are no errors, I hope my comments have been helpful, good luck.

  Marked as helpful

  0

  ---

  

  Damilola Olanrewaju•310

  @Dami-MoorePosted over 2 years ago

  @Sdann26 Thank you so much, I'll effect the things you have said!

  0