Design comparison
Solution retrospective
Would love to hear feedback on this challenge. I think I've done an ok job of managing focus but would be interested to know how else I could improve the accessibility. I did see on mdn that role="comment"
is an option but it also says that browser support isn't great for it.
Thanks for any advice.
Community feedback
- @visualdennissPosted over 1 year ago
Great job with this challenge! Everything seems to be working fine and it is also great that you have used context and reducer, making the code much cleaner than my version, which i also plan to refactor to reducer sometime soon.
Also i like that you added a real, functioning like system. When i was doing the challenge, to me it made more sense to jump from 13 to 11 when counting likes, if the user has upvoted already, (when there are 12 votes to start with), but clicks to downvote from that state, instead of 13-1 = 12, should be 11 straight. Because objectively there are 12 votes, you can either downvote or upvote, meaning only 11 or 13 should be possible with voting, and to take back the vote, simply clicking on the given vote should revert it (e.g. if upvoted to 13, clicking on upvote again should take it back to 12, instead of clicking minus). It is a very minor thing, but this is a more common practice in apps usually i believe. So it might be some food for thought.
Hope you find this feedback helpful!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord