@seanred360
Posted
I recommend you use object destructuring in ALL of your components, you have a lot of duplicate variable names and collisions. I was very hard for me to understand what was going on. Pretty easy fix though. Check my pull request on Github for details on how to do that. Good job so far, you seem to grasp Javascript pretty well. You just need to learn the best practices for React.
Marked as helpful
@JanWu100
Posted
@seanred360 Thank You very much for help, that was also first time I had anyone contributed to my code on github so I could learn a bit about that aswell. And also thank You for the nice words, I really needed that after not being able to fix all bugs with that challenge :) appreciate that
@seanred360
Posted
@JanWu100 I am also doing Github for practice lol. It's really hard to get started collaborating on Github so I figured I would just find other beginners that also want to break into it.
You have a good grasp on programming for sure, you just need to know "The React way" of thinking, and how people typically structure their apps.