Interactive card details form with Tailwind & React Hook Form

Community feedback

• 

  Maksim•590

  @MaxTarasevichPosted about 2 years ago

  Hi!

  Good work!

  But You should still work on field validation!

  CARDHOLDER NAME - I can fill in completely numeric values.

  EXP. DATE (MM/YY), CVC - need to be checked for data correctness and string length.

  It is also worth fixing the mobile version, at a screen resolution of less than 450 the design layout breaks!

  Also you forgot to delete in the App component console.log:

  const onSubmit = (data, e) => console.log(data, e)
   const onError = (errors, e) => console.log(errors, e);
  

  You have all the application code in the App component, the application is small, but it’s still worth breaking it into components. You have five states, try representing the data as an object!

  I hope my feedback will be helpful!

  Marked as helpful

  0