Interactive card details form using React & Sass

Community feedback

• 

  David•8,000

  @DavidMorgadePosted over 2 years ago

  Hello Vietano, congrats on finishing the challenge!

  I will try to answer your questions and give you my personal opinion on your code:

  • I think yes, 4 nested CSS selectors are hard to read, you should stick to maximum 3 to make your code more readable and easy to change / understand, try maybe using BEM to avoid excesive nesting or just call the class in another block on your SCSS.

  • Well I can understand it, but it can be more easy to read if you change a bit your habits of your Javascript style, but this can be a hard path and it will just come with time, for example:

  Instead of for of loop (wich yes, they run faster but are way less readable), use array methods like map(), forEach() etc... instead of using if else checks try using ternary operators or logical && || operators, this are modern features that can reduce your code a lot and make it more readable. Dunno how exactly Vite works, since I have only used Create react app and NextJS but you should divide your project in a lot of components, instead of having everything on one file.

  • As I said before I think using Array methods here could have done the job easily for you.

  Hope my feedback helps you, if you have any questions don't hesitate to ask, you did a great job, welcome to the react community of frontendmentor!

  Marked as helpful

  1

  ---

  

  kxnzx•870

  @kxnzxPosted over 2 years ago

  @DavidMorgade Hi David, could you also take a look at my solution? I also finished this challenge and need some help with JavaScript..It will be much appreciated!

  1

  

  David•8,000

  @DavidMorgadePosted over 2 years ago

  @kxnzx I was just looking at it! let me try to see if I can get the error, will comment you there, gonna fork your repository to see it better

  0

  

  kxnzx•870

  @kxnzxPosted over 2 years ago

  @DavidMorgade Thanks in advance!

  0

  

  vietan0•430

  @vietan0Posted over 2 years ago

  @DavidMorgade Thanks a lot for the detailed suggestions! I'll happily note these down for further learning!

  1