@noheezybucket
Posted
Hellooo I checked the result you provided for this challenge.
In my opinion :
- You should check the position of the card it's not well centered on the Y-axis.
- You should check the responsiveness of the page so it can adapt to all types of screen.
- Check the report for your HTML code, seems like you did not used the max-length property the right way.
- For the number input you did not limit the number of input to 16 I think it's stopping at 19 numbers.
Except that you did a great work. Good job mate.
Marked as helpful
@DarKaRor
Posted
@noheezybucket
I was wondering why the max-length wasn't working! I ended up just making the max-length functionality in JS since I didn't want to just put max=99 or something like that
For the numbers I decided to let the user input the spaces (if they choose to) and then let the validation and sanitization do the rest, if you try submitting the form with more or less than 16 numbers it wouldn't let you (Though I just notice it would let you input a bunch of spaces and at least one number)
Thanks for the feedback!
@noheezybucket
Posted
@DarKaRor okay I got it but don't you think it would be better if you've putted the spaces automatically ?
