Interactive card implemented using Vue and Typescript

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  hey Katja Danilova😄, congratulations on completing the challenge here are a few tips to make your site better..

  1.I see that you have used the body->flex but that property is causing extra space(margin) on the left and right sides...

  2.The validation seems very nice..The only thing which seemed like a bug is when I am entering the ii into the YY input field...there was no validation error..

  I really liked the button shaking-animation upon entering the wrong input great job, happy coding👍🏻🔥💯

  Marked as helpful

  0

  ---

  

  Katja Danilova•340

  @katjadanilovaPosted almost 2 years ago

  @sulemaan7070 thanks for your comments, and a good catch there about validation of exp.dates and CVC - indeed, I didn't check if user inputs numbers there. Body having display: flex does not cause margins, it's just that body has justify-content: center so that even on big screens content is located in the center.

  1
• 

  Katja Danilova•340

  @katjadanilovaPosted almost 2 years ago

  Do you have any ideas why do I get an error "Attribute modelvalue not allowed on element div at this point." in HTML validation report?

  0