interactive card details form

Community feedback

• 

  Mohammed Fakih•1,590

  @javascriptor1Posted 12 months ago

  Nice job Oussama. Here are some quick notes as I just uploaded my solution an hour ago:

  1- Always use semantic tags instead of generic ones like div. Use the form tag instead of div and use footer tag instead of section for the footer note.

  2- Your JavaScript logic for input checking does not work well. Month and year fields accept letters, not digits. Try to type letters "DD" in the month input field and it won't show errors. In addition , if you type for example 13 in month field , it will show the wrong error message about blank field despite the field is not blank but contains invalid month. Change the error message.

  3- add border color for input while in focus status.

  4- The year format is wrong. It should be 2 digits only (YY) as shown in the challenge. You made it in YYYY format which is not correct.

  5- In mobile screen (375px) , the footer is overlapping and touching with the confirm button.

  6- CVC filed should be wider for smaller screen to edge with top input fields from the right.

  Keep coding and good luck

  Marked as helpful

  1

  ---

  

  Ouss_Ach•810

  @OUSSAMAACHICHEPosted 12 months ago

  Thank you, mohammed

  • I will fix that

  0