Interactive Card Details build with html css and js

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Pparg•160

  @PpargPosted over 1 year ago

  Hi, very nice work. I can see when i click on the submit button that the expiration month adds a 0 at the beginning when i try to submit the 09 input. Try to add a condition at this part of your code, maybe a condition given the length of inputMonth.value : inputMonth.value = parseInt(inputMonth.value) > 12 ? "12" : parseInt(inputMonth.value) < 10 ? 0${inputMonth.value}:${inputMonth.value};

  Marked as helpful

  1

  ---

  

  victor247k•200

  @victor247kPosted over 1 year ago

  @Pparg thank you

  1