Interactive card detail using CSS Flex and Vanilla JS

Community feedback

• 

  Adelinked•370

  @AdelinkedPosted about 2 years ago

  Hello Antoine, I saw your preview site and I’ve some suggestions you can consider applying to your solution :

  • Make the site responsive by adding the appropriate media queries and css rules to display correctly (following the design provided in the challenge for mobile devices) especially for small screen devices.
  • Improve the form input validation for example when testing your solution i was able to submit the form with a card number with less than 16 digits. Same thing for the date and cvc fields where it displays "can't be blank" when i enter something other than numbers.

  0

  ---

  

  Antoine Bollinger•40

  @antoinebollingerPosted about 2 years ago

  @Adelinked thank you so much for your feedback. I'm a bit surprised because I added the required css rules for mobile, the site should respect the design (with max width 375px). I'll check what is wrong. The validation part should be improved as you suggest, I agree and I'll check this asap. Thanks again,

  1

  

  Adelinked•370

  @AdelinkedPosted about 2 years ago

  @antoinebollinger You're welcome.

  0