Submitted about 1 year ago
Interactive card component using Html, Css, Js and Jquery
@Georgelafayen
Design comparison
SolutionDesign
Solution retrospective
Hi There 😁!
This is my solution to the challenge, any advice on how to improve my code is welcome!
Community feedback
- @CorfayaPosted about 1 year ago
Hello Giorgio! Your code is very clean, congratulations!
Just remember the Alternative Information (alt) attribute, some users may have to use screen readers. For example:
<img src="img.png" alt="This is an image" >
But this is only a detail, not a code problem.
Well done indeed! Laura
Marked as helpful1 - @matiasluduena23Posted about 1 year ago
Hi Giorgio! It looks great you project. Just two advice that might help you.
- Start to use semantic HTML, that means use differents tags than a div, all your content could be in a
main
tag and you can also use anarticle
for your cards. Look this when you have time. - Try to avoid width and height, instead use max-width and max-height, it will do your elements responsive. Change it in your
containerOne
class with a more higher number and play with that numbers.
Good code!
1@GeorgelafayenPosted about 1 year agoThank you so much @matiasluduena23 for your time and tips, I will definitely put what you showed me into practice!
0 - Start to use semantic HTML, that means use differents tags than a div, all your content could be in a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord