Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Interactive Card Component ---- Flexbox and Vanila JS.

@TotallySly

Desktop design screenshot for the Interactive rating component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I made an error where initially I was using buttons instead of radio buttons. This meant that I was finding it impossible to create the greyed out 'active' state with the ratings. However, I received some help and it worked and made life so much easier.

I was wondering if using a string template literal would be possible. I tried but I could not quite figure it out.

Also, my JS are not within functions. Is this bad practice? Should I be saving the script within functions?.

Thanks!

Community feedback

kirty 380

@kirtymeena

Posted

Hi Dizzy_Sloth,

  • On lines 37 and 41 in the index.html file there are open and closing brackets, I am not sure why they're there but I can see them in the UI and according to the design there are no such brackets in UI.

  • Users should not be able to submit if they haven't selected a rating.

Overall, it looks great. Keep coding 👍.

0

@TotallySly

Posted

@kirtymeena Thank you for the feedback. The first one. What a rookie mistake..... I will fix this asap.

And of course. I was getting so fixated on trying to get it to work that I forgot that conditional.

Thank you!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord