Interacitve Rating component with Flexbox and vanilla JS
Design comparison
Solution retrospective
What should I focus on learning or improving next? Do I look ready enough to advance to the junior challenges here at frontendmentor? Is some part of my css longer than it needs?(shortcuts or simpler way to do fix a problem)
Community feedback
- @TechNechPosted over 2 years ago
Hey, hope you are doing good. I would like to suggest a few changes in your challenge:
-
In your
.card
class, removeheight
anddisplay
properties. -
In your
.rating a
class, removemax-width
and addwidth: 50px; height: 50px;
, changeborder-radius: 50%;
andpadding: 1rem;
Also I have noticed you are using
rem
andpx
values mixed up which creates lot of issues. What I have learned is to userem
values for things likepadding, margins etc
andem
values forfonts
, which also helps in responsiveness.Hope I helped, Take care.
Marked as helpful0@purplehippo911Posted over 2 years ago@TechNech Thanks for the feedback, it helped quite a lot.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord