@DavidMorgade
Posted
Hello Pablo, congrats on getting the solution for this challenge!
In my opinion your layout looks perfect, nice use of flex-box everywhere, you did a pretty good job with that.
The only things I would change would probably the main tag, instead of having it separated through divs you could perfectly go for two section!
Also the sub-sections are related each one wich its content, they would fit perfectly on an article tag.
Good job with the rest of the markup, also nice job with the transitions (people usually don't add them, dunno why).
Hope my feedback helps you, I suggest you to go for bigger CSS projects as challenges!
Marked as helpful
@p4bloxx
Posted
@DavidMorgade Hi David, many thanks for this super constructive comment, you are right about the use of semantic tags, I have to be more careful in the structure phase.
Thanks also for the transition issue, I always like to give a little personal touch in challenges;)
I am working on some more demanding challenges, first of all the one on the space agency, I hope it goes well.
Cheers
@DavidMorgade
Posted
@p4bloxx The space tourism challenge is a really good challenge to work in your CSS and in your JS too, nice choice! and good luck with it!
@p4bloxx
Posted
@DavidMorgade many thanks! ;)
