Design comparison
SolutionDesign
Solution retrospective
This was a good exercise, i loved the design of this site. Nevertheless it took me a few hours. Your feedback or any suggestions to improve my code is very welcome.
Community feedback
- @enzo-mirPosted 12 months ago
Hello that is a very nice solution the only issue is the footer doesn't look like the design :
- There is no background color
- The shape doesn't appear this way
And concerning your code : Nothing to say you have sementics tags maybe in JavaScript :
- Declare readable contants such as "top_nav" instead of "x"
- Use
classList
to improve the code it will be better withclassList.add()
,classList.remove()
orclassList.toggle()
Well done ;)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord