Insure Landing Page with Flexbox & SASS

Community feedback

• 

  Mojtaba Mosavi•3,760

  @MojtabaMosaviPosted over 3 years ago

  Hi!, Great stuff, looks nicec and reponds well. Looking att you markup the only thing that comes to mind is subtle modifications that you can make to make even more awesome.

  1 I think in in some places your markup is bloated and keep in mind this is only my take on it. For example in you footer I think a sing nav element could do the job mainly because it's meant to contain the main navigation of a site. Another example is that in may places you define div for certain styles while you can accomplish the same thing without it, for example the column that you difine in your footer is not neccesary and you can put the styles on the footer-nav. This is only looking at you code through my dev glasses.

  Keep coding :)

  1

  ---

  

  Dex•225

  @tihuskyPosted over 3 years ago

  @MojtabaMosavi

  Yeah, I think I tend to make things too complicated. I hope it will get better with more experience! I'll try to make the markup for the footer a bit simpler at least.

  Thank you for your feedback as well!

  0
• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Dex! 👋 Congrats on finishing another challenge! 🎉 Your solution looks very good and also responds well. Here's my few tips:

  • It is good that you think about apply :focus pseudo-class to your interactive elements but keep in mind that focusable elements they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Dex•225

  @tihuskyPosted over 3 years ago

  Thanks for your feedback, @tediko!

  That article was really interesting and I've tried to make the focus state on links, buttons and social icons more obvious 😃

  0