Insure Landing Page with bootstrap 5, html, css and js

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  DECORATIVE SVG'S ♨️:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.

  ---

  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.

  ---

  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.

  ---

  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

  ---

  Example:

  <img src="images/decorative.svg" alt="">
  
  

  <img src="images/icon-snappy-process.svg" alt="icon-snappy-process">
    👇
  <img src="images/icon-snappy-process.svg" alt="">
  
  

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Doston Nabotov•950

  @dostonnabotovPosted over 1 year ago

  Hi, there! 👋

  Congrats on completing the challenge!

  Really liked your solution. But, here are some suggestions I have:

  • I found a bug with your mobile navigation toggle. When using it on my phone, I noticed that icon and navigation state is switched. In other words, when I open nav menu, icon turns into "menu" instead of "x".

  Possible solution: I think it's causing by your JavaScript code, where you've specified the isIconEnabled to true. I think, by default it should be set to false, because nav menu will be closed when you first load the page.

  • (In my opinion) You have way too many media queries in your CSS. 3 and 4 queries are way too much to handle as if you are trying to micro managing your website.

  Possible solution: If you're having issues with big spacing on larger devices and small spacing on small devices, try better learning the clamp(). See how you unleash the power, by not just applying to font sizes, but also in your spacing and other several places.

  Good luck on your coding journey.

  Marked as helpful

  1