Insure Landing Page (took me over a month, please give me feedbacks)

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  Hello, Nguyen Nguyen! 👋

  Good work on this challenge! 👍 Your solution looks good and your HTML is semantic! 👏

  Here are a few things I'd like to suggest,

  • Adding some hidden text inside of or adding an aria-label to each of the social media links in the footer of the page. That's so that these elements can be identified by screen readers. Doing so should help get rid of a couple errors on your solution report. 😉
  • Adding overflow-x: hidden to the body to prevent any unwanted horizontal scrolling on the page.
  • Adding a max-width to some of the text elements on the page in table views so that they aren't so wide when the layout first changes from desktop to tablet (this should help improve the look of a couple of things at around 945px).
  • Considering splitting your Sass file into smaller files (called partials) since your main Sass file is quite long (over 400 lines). Doing so will help keep your project organized and make it easier to write and maintain your styles.

  Hope you find this helpful. 😊

  Keep coding (and happy coding, too)! 😁

  Marked as helpful

  2

  ---

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  One more thing! 😆

  If you'd like to make the transition of your mobile menu smoother, set the value for left for the menu container to -100% (not -1000px). This'll ensure that the container is offset to the left by just the right amount and the transition in/out will be much slower and therefore smoother. 😉

  Marked as helpful

  1

  

  Nguyen Nguyen•340

  @jesuisbienbienPosted over 2 years ago

  @ApplePieGiraffe wow! thank you so much for your response. I really appreciate it.

  1

  

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 2 years ago

  @jesuisbienbien

  Glad to help! 😀

  0