Insure landing page - HTML, CSS and a little JS for the burger menu

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello there, Dave! 👋

  Good work on this challenge! 👍 You've done a nice job, as usual, (everything looks pretty good and responds rather well)—and I like the spinning animation you added to the mobile menu icon (just add something like overflow: hidden to the body when the navigation is toggled)! 😀

  A few things I'd like to suggest are,

  • Increasing the size of the text of the navigation links in the footer of the page in the desktop layout (they are quite small, at the moment).
  • Adding overflow-x: hidden to the body to get rid of a horizontal scroll bar that is showing up along the bottom of the screen in the desktop layout.
  • Typically, vertical scrolling is disabled when the mobile navigation is toggled so that users can just focus on the options they have available to them (and I think things feel a little out of place if you are able to scroll down since now part of the page is covered by the menu and you to disable it anyway in order to access the rest of the content on the page). As long as there is a clear way to disable the mobile menu (so that users can easily exit out of it), I think disabling vertical scrolling when the mobile navigation is toggled would be a nice idea! 😉

  Of course, keep coding (and happy coding, too)! 😁

  2

  ---

  

  P

  Dave•5,295

  @dwhensonPosted over 3 years ago

  @ApplePieGiraffe thanks as always for the tip top feedback. Much appreciated.

  Both you and @uzoway have the same feedback on the nav so I’ll look into that.

  I’m about to start reviewing some of my recent challenges and updating them with the feedback I received so I’ll put this one on the list.

  Thanks again!

  1
• 

  Uzochukwu Okafor•355

  @uzowayPosted almost 4 years ago

  I just posted screenshots of what I mean

  1

  ---

  

  P

  Dave•5,295

  @dwhensonPosted almost 4 years ago

  @uzoway thanks! I can see what you mean now.

  I think I'm OK with users being able to scroll down from the mobile nav. I wanted to keep the functionality as much like a desktop nav as possible - so users aren't trapped in it.

  Also position fixed would bring some other problems as the top of the nav (the part with the logo and nav button) is not part of the pop-up but just the original nav. I'll have a think how I could go about addressing this.

  Thanks! Appreciate the feedback.

  0

  

  Uzochukwu Okafor•355

  @uzowayPosted almost 4 years ago

  @dwhenson Okay... It is no problem

  0
• 

  Uzochukwu Okafor•355

  @uzowayPosted almost 4 years ago

  Hello Dave! I just visited the site(on mobile) and I must say you did well. Although, there's something I'd like to point out. On the mobile layout, the hamburger and Mobile navigation page is only accessible on the first page. I think it should be fixed(position) so that at any point on the page, one can easily navigate the site.

  I'm actually working on this challenge and you just motivated me to finish it😄

  1

  ---

  

  P

  Dave•5,295

  @dwhensonPosted almost 4 years ago

  @uzoway thanks for the feedback. I’m a bit confused though about the mobile nav issue. I thought there was only one page to this challenge ??? Can you clarify what I missed please.

  0
• 

  Uzochukwu Okafor•355

  @uzowayPosted almost 4 years ago

  On the slack channel

  0