Design comparison
SolutionDesign
Solution retrospective
Hello everyone ! 👋
Here is my solution for this challenge. Let me know your thoughts and feedbacks on this. Thanks!
Community feedback
- @sahand-masolehPosted over 2 years ago
Hello there! great job! I just noticed a few things:
- I can't open the nav menu mobile view, nothing happens when I click the button.
- Set a height for your hero image. Right now it can go from very tiny to bigger than the view port at 700px width. Set a height with the
object-fit: cover
property so that it wouldn't have unpredictable behavior. - Right now you're loading all images and hiding/unhiding them with css based on view size, this negates the point of having multiple resolutions of one image. Use the
picture
tag or theimg
tag withsrcset
to only load the image that is needed based on a media query.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord