I'M FINALLY DONE WITH THIS PROJECT!

Community feedback

• 

  Fidel Lim•2,775

  @fidellimPosted about 3 years ago

  Hello Andrew, for the location SVG, one solution I would suggest is by adding align-items: center. This will fix the issue. Also, there are just a few things I would like to suggest as well. First, I noticed that there is some space on the sides of the page. As I've looked at your CSS, you added a margin. It would be great to just disregard that one. It will look more similar to the design made. Lastly, on the sections of the page (wherein there are images and texts side by side), you have used floats for the images. I believe nowadays, developers don't use it that much anymore. The reason is that there is a flexbox and grid. I've seen that you have used flexbox already and might want to use that instead. To solve this issue, just add display: flex to the parent containers (flowing, flowing2, and your) and that will be it. For mobile view, just add "flex-direction: column" on the media query you prefer. I hope it helps! Good luck and well done :)

  Marked as helpful

  0
• 

  Dušan Lukić•1,660

  @dusanlukic404Posted about 3 years ago

  Hey Andrewfpai, for the svg image add align-items: center; to your .location and your problem will be fixed. Also, I suggest you to take a look on accessibility and HTML issues because there are a lot of problems, so you should learn more about them. They will be important in your future career as a Front-end Developer. In your future projects I suggest you to always make by default margin and padding 0 and then to add them properly. In this case your header and first container have that margin and adding unnecessary space. First and third illustrations should have max-width: 100%; so they won't overflowing the container. Buttons needs transition.

  Marked as helpful

  0