idk if this is responsive

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 10 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="card"> element with the proper semantic element <main> in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 10 months ago

  Looks great!

  Regarding the div issue, you could replace some with semantic tags like header and footer, to match your classes. Then, the div with the class tittle you could replace with an h1. More info: HTML Semantic Elements.

  Also, the div with the card class could be put directly in the main and delete said div. Then, pass the styles that the main had to the body.

  Marked as helpful

  1
• 

  Paulo Vitor Ferreira Gonçalves Pivotto•30

  @high-rollsPosted 10 months ago

  Thanks a lot for the help guys. I changed the code to include the accessibility landmarks, but I still kept them inside of the <div> with the card class, the reporter now shows no issues. I'll study more about landmarks and how to properly use them, but this is good enough for today.

  0