i was using plain HTML , CSS

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted over 3 years ago

  Hello, Shomy032! 👋

  Congratulations on completing your first Frontend Mentor challenge! 🎉 Good job on this one! 👏

  In addition to RayaneBengaoui's helpful feedback, one or two very minor things I'd like to suggest are,

  • Adding a favicon to your page (there's one included in the free starter files for this challenge that you can use).
  • Perhaps making the card component a little wider in the mobile layout as long as there's room (you can do so by adding width: 100% to the card component and then adding a max-width to make sure that it doesn't become too wide).

  Hope that helps a little. 🙂

  Keep coding (and happy coding, too)! 😁

  1

  ---

  

  Shomy032•270

  @Shomy032Posted over 3 years ago

  @ApplePieGiraffe thanks for feedback, it means a lot . I totaly forgot favicon :)

  1
• 

  Rayane•1,935

  @RayaneBengaouiPosted over 3 years ago

  Hello Milos,

  Congrats for completing your first challenge ! 🙂

  I'd like to suggest :

  • Adding text-transform : uppercase on your <h2> to have uppercase titles like the design.

  • Decreasing opacity property on your <p> tags. They are not 100% white if you look carefully.

  • Adding line-height to your <p> tags to space lines.

  • Color of <h2> and background of <button> are also not entirely white (hsl(0, 0%, 95%)).

  Overall, well done for the challenge and happy coding ! 😃

  1

  ---

  

  Shomy032•270

  @Shomy032Posted over 3 years ago

  @RayaneBengaoui Thanks for the feedback, it means a lot :)

  0