Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
grouping of dev and adding font from an external site
What challenges did you encounter, and how did you overcome them?sizing the container
What specific areas of your project would you like help with?none at the moment but with JS I will need a strong support
Community feedback
- @developer-rubenPosted 8 months ago
Hi!
Here are my HTML tips based on your solution:
- Don't forget the <main> tag on your page to improve accessibility
- I see you used BEM in your body__section, good job! However, you didn't apply it in the rest of your component?
- On that same body__section tag you used the div tag, which has no semantic meaning, I would've used the section tag instead
- Use the footer html tag for the attribution section
And for the CSS:
- Try to keep consistent in your selectors, try using classes only, since this is a component and can screw up the rest of the page if you want to use this component in an exciting sting page
- Once again, try to keep using BEM for all selectors
- Avoid pixels as a unit for font sizes, use em or rem instead
Best, Ruben
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord