@Islandstone89
Posted
Hi Ayush, you did a good job!
Here is some feedback I hope you find helpful :)
HTML:
-
Every webpage needs a
<main>that wraps all of the content, except for<header>andfooter>. This is vital for accessibility, as it helps screen readers identify the "main" section of a page. Change.containerto a<main>. -
The alt text must also say where it leads(frontendmentor.io).
CSS:
-
It's good practice to include a CSS Reset at the top.
-
Add around
1remofpaddingon thebody, so the card doesn't touch the edges on small screens. -
Remove all properties on
.container. -
Remove the margin on the card.
-
Add a
max-widthof around20remon the card, to prevent it from getting too wide on larger screens. -
font-sizemust never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead. -
On the image, add
display: blockand changewidthtomax-width: 100%- the max-width prevents it from overflowing its container.
@ayushyadavz
Posted
@Islandstone89 I have updated the Code according to your approach. Can you please check it now and tell me if i did it correctly or not?
@Islandstone89
Posted
@AayushYadavz well done. There are only a few small adjustments left:
- Remove the
<div>between<main>and.card. Your structure should look like this:
<main>
<div class="card">
<img>
<div class="text">
<h2>
<p>
</div>
</div>
</main>
-
Change alt text to "QR code leading to the frontend mentor website".
-
The default value for
font-sizeis1rem, so you don't need to declare that explicitly.
Keep up the good work :)
@ayushyadavz
Posted
@Islandstone89 I have submitted 2 more solution of some challenges can you please review them and tell if there is need to change something because I love your review.
