I used SASS mainly and some of the basic CSS

Community feedback

• 

  T

  Chamu•13,340

  @ChamuMutezvaPosted 9 days ago

  Hi MuftiBinHabib

  Congratulations for taking your first challenge. Here are a few things to look at.

  • landmark elements such as the main are needed for the organisation and structure of your website. This challenge needs the main element whose contents are focused on the main reason of the website.
  • the second heading element should be a p element. Since this is just a component the first heading element can be an h2 element. At the same time I should explain further that in a complete website your current settings of heading order will be fine.
  • using explicit width should be with caution as that can cause your site to be unresponsive. You need to create a site that is responsive . That can be achieved by a combination of max-width in rems and width as a percentage 100% . The idea here is to make the site to grow to a certain width on desktop but as the same time allow it to scale on small devices.
  • always use a Modern CSS reset stylesheet to normalise your CSS. One common one is by Andy bell .
  • avoid unnecessary chaining your styles like .card .heading2 by simply keeping the specificity as low as possible. Here you can just use .heading2
  • the component is not centered. Research on Flexbox , that will help you to center the component

  0