@correlucas
Posted
๐พHi Fernando Sosa, congratulations for your first solution!๐ Welcome to the Frontend Mentor Coding Community!
I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:
Something I've noticed in your code is that in many occasions you've added some <div>
to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div>
or <main>
if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:
<body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
โ๏ธ I hope this helps you and happy coding!
Marked as helpful