Design comparison
Solution retrospective
Accordion with SASS and BEM made...if you have any suggestions please go ahead and tell me what i could have done better, especially in the JS part.
Community feedback
- @cconner57Posted almost 4 years ago
Hi Radu,
Great job on the project. Everything looks great and your coding looks good! Only criticism I have that the container's height and width are a lot bigger than the example's height and width
1@gloriellPosted almost 4 years ago@cconner57 Thank you for the feedback, on my display it seems to be much smaller i am not sure why it so big in here.
1 - @DeKodingCodePosted almost 4 years ago
The project looks good! Does seem slightly bigger than the brief, but I see you mentioned that you aren't sure why that is.
The only thing I can pick out is to open each accordion, I can click anywhere in the title of the question (except the arrow) and to close it's the opposite. I need to click on the arrow to able to close the question.
0@gloriellPosted almost 4 years ago@DeKodingCode haha true, i'll keep on eye on it JS seems difficult for me a bit i'm, still learning but i'm gonna work on this "bug" thank you for the feedback it is very much appreciated.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord