i used only html and css and used flex techniques in css with html

Community feedback

• 

  P

  Øystein Håberg•11,010

  @Islandstone89Posted 4 days ago

  HTML:

  • Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" content. Wrap the card in a <main>.

  • I would remove the <div> around the image, as it is not needed.

  • Always include an alt attribute on images! If the image is purely decorative, the alt text should be empty: alt="". This image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(the frontendmentor website). A good alt text would be "QR code leading to the Frontend Mentor website."

  • I would change the heading to a <h2> - a page should only have one <h1>, reserved for the main heading. As this is a card heading, it would likely not be the main heading on a page with several components.

  • It's common to give elements a class. Ideally, your HTML would look like this:

  <main>
    <div class="card">
      <img src="images/image-qr-code.png" alt="QR code leading to the Frontend Mentor website." class="qr-image">
      <h2 class="heading">Improve your front-end skills by building projects</h2>
      <p> class="text">Scan the QR code to visit frontend mentor and take your coding skills to the next level</p>
    </div>
  </main>
  

  NB: My class names are just suggestions, but you should a meaningful name.

  CSS:

  • Including a CSS Reset at the top is good practice.

  • I recommend adding a bit of padding, for example 16px, on the body, to ensure the card doesn't touch the edges on small screens.

  • Move font-family to body.

  • On the body, change height to min-height: 100svh - this way, the content will not get cut off if it grows beneath the viewport.

  • Remove the margin on the card, it is not needed since the card is centered using Flexbox.

  • Remove all widths in px. We rarely want to give a component a fixed size, as we need it to grow and shrink according to the screen size.

  • We do want to limit the width of the card, so it doesn't get too wide on larger screens. To solve this issue, give the card a max-width of around 20rem.

  • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

  • I wouldn't set an explicit font size on the paragraph, as its default font size of 1rem (equals 16px) is perceived as the minimal text size for accessibility.

  • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

  • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

  • On the image, remove padding. Add display: block, height: auto and max-width: 100% - the max-width prevents it from overflowing its container. Without this, an image would overflow if its intrinsic size is wider than the container. max-width: 100% makes the image shrink to fit inside its container.

  • The card needs padding on all sides of the card. Replace padding: 10px 0 with padding: 16px.

  Marked as helpful

  0