@Wuczek
Posted
Great job!
I would recommend to use
letter-spacing:2px;
property instead of adding spaces in your HTML in <a> tag :
<a data-rating="submit" href="" class="btn-submit">S u b m i t</a>
Marked as helpful
Submitted
@victorgfz
I think the js could a little bit better, more optimized. I found some difficult on making some of the animations with js.
@Wuczek
Posted
Great job!
I would recommend to use
letter-spacing:2px;
property instead of adding spaces in your HTML in <a> tag :
<a data-rating="submit" href="" class="btn-submit">S u b m i t</a>
Marked as helpful
@visualdenniss
Posted
Great job completing this challenge successfully and making it fully responsive. You animations looks really nice!
I'd have an alternative suggestion for later on to use for animations: https://michalsnik.github.io/aos/ When you need a simple animation, it saves a lot of time instead of writing js. It works by simply atting an attribute to ur html. You just need to install the library or simply use it as cdn link. For simple animations it works great and i use this too.
Hope you find this feedback helpful!
Marked as helpful
@0xabdulkhaliq
Posted
Hello there π. Congratulations on successfully completing the challenge! π
HTML π·οΈ:
non-semantic
markup, which lack landmark for a webpage<div class="card review">
the with semantic element <main>
in your index.html
file to improve accessibility and organization of your page.<div>
or <span>
<main>
element should include all content directly related to the page's main idea, so there should only be one per pageI hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord