I used mostly flex to organize the items and added animation with js
Design comparison
Solution retrospective
I think the js could a little bit better, more optimized. I found some difficult on making some of the animations with js.
Community feedback
- @WuczekPosted over 1 year ago
Great job!
I would recommend to use
letter-spacing:2px;
property instead of adding spaces in your HTML in <a> tag :<a data-rating="submit" href="" class="btn-submit">S u b m i t</a>
Marked as helpful1 - @visualdennissPosted over 1 year ago
Great job completing this challenge successfully and making it fully responsive. You animations looks really nice!
I'd have an alternative suggestion for later on to use for animations: https://michalsnik.github.io/aos/ When you need a simple animation, it saves a lot of time instead of writing js. It works by simply atting an attribute to ur html. You just need to install the library or simply use it as cdn link. For simple animations it works great and i use this too.
Hope you find this feedback helpful!
Marked as helpful0 - @0xabdulkhaliqPosted over 1 year ago
Hello there π. Congratulations on successfully completing the challenge! π
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML π·οΈ:
- This solution generates accessibility error reports due to
non-semantic
markup, which lack landmark for a webpage
- So fix it by replacing the element
<div class="card review">
the with semantic element<main>
in yourindex.html
file to improve accessibility and organization of your page.
- What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like
<div>
or<span>
- They convey the structure of your page. For example, the
<main>
element should include all content directly related to the page's main idea, so there should only be one per page
I hope you find this helpful π Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord