@Hassiai
Posted
Replace <div class="qr-code"> with the main tag to fix the accessibility issues. click here for more on web-accessibility and semantic html
Give the body a background-color. To center .qr-code on the page using flexbox or grid instead of margin, add min-height:100vh; display: flex; align-items: center: justify-content: center; or min-height:100vh; display: grid place-items: center to the body.
USING FLEXBOX:
body{
min-height: 100vh;
display: flex;
align-items: center;
justify-content: center;
}
USING GRID:
body{
min-height: 100vh;
display: grid;
place-items: center;
}
For a responsive content, replace the width in .qr-code with max-width and increase its value and the padding valu. max-width: 320px padding:16px
.
Give the img a max-width of 100% for a responsive image instead of a width.
Give h1 and p the same font-size of 15px which is 0.9375rem and the same margin-left, margin-right and margin-top values. Give p a margin bottom value and a font-color of hsl(212, 45%, 89%).
There is no need to give .qr-code a border value. give it a background-color of white. Use the font-family that was given in the styleguide.md in the zip folder you downloaded.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
Marked as helpful