Design comparison
SolutionDesign
Community feedback
- @mattstuddertPosted about 5 years ago
Nice work on this challenge! Here are some pointers after taking a look at your code:
- If you uppercase text in your HTML, screen reader software will read it out letter-by-letter. So for the main heading, I'd write it as "We're" instead of "WE'RE". You can then use
text-transform: uppercase;
to visually transform it to match the design. - I'd also only have one
h1
element, so I'd wrap all the "We're coming soon" text in a singleh1
and then use aspan
to differentiate the text for styling. - I'd recommend avoiding
position: absolute
for the image and would instead use Flexbox or CSS Grid to get the content into two columns. - I'd also recommend avoiding
position: relative;
combined withtop
values that you're currently using to move the content on the left. Instead, I'd use a combination ofpadding
on the parent element andmargin
on the inner elements to handle the spacing.
I hope these tips help. Keep up the great work! 🙂
0@macbrightiePosted about 5 years ago@mattstuddert thanks a lot appreciate will definitely adhere to this during my next project
0 - If you uppercase text in your HTML, screen reader software will read it out letter-by-letter. So for the main heading, I'd write it as "We're" instead of "WE'RE". You can then use
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord