Skip to content
Submitted 2 months ago

I used javascript ,css and html

moses ayodele•150
@mowzayo
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I improved with my javascript but i need to learn to write it better without help.

What challenges did you encounter, and how did you overcome them?

adding js to places i had passed, it was like re writing the logic.

What specific areas of your project would you like help with?

java script writing.

Community feedback

  • Skyler Ang•330
    @skyleranglhPosted 2 months ago

    Hello, and good job on completing the project. Here are some improvements I can recommend. You can center the title with text-align instead of hard coding a padding left. Some colours and spacing can be adjusted to match more on the design.

    JavaScript wise, I noticed your functions could be a little bit too long-winded. You can try to break them down into descriptive methods to improve the readability so you don't have to describe everything with comments.

    User experience wise, I noticed there is no validation on the bill input and I can't tell which tip option is being applied. The number arrows could make the input negative which can yield unexpected results from a user's perspective.

    Other than those, I like the tip amounts are changing based on input change.

    I hope these comments can help.

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord