I used HTML, SCSS and Js

Community feedback

• 

  T

  Grace•31,270

  @grace-snowPosted almost 4 years ago

  Hi, I think this looks really good and works well, you should be pleased with it.

  Im not sure what you mean about elements having no space on mobile, all looks like fine spacing to me.

  Only change I'd make I think is to read all the data from the json to loop over and create the elements. But that it harder and nothing at all wrong with doing it how you have done with everything in the html already.

  Well done, this one isn't the easiest of challenges!

  2

  ---

  

  Olaleye Blessing•355

  @Olaleye-BlessingPosted almost 4 years ago

  @grace-snow

  I thought of looping the json data but I didn't know my way round if multiple options are included. I'll try it at a later time

  Thanks for the encouragement

  0
• 

  Abhik•4,840

  @abhik-bPosted almost 4 years ago

  Happy new year Olaleye 🎊

  Your solution is fantastic and it is very responsive 💯, I liked the hover states and over all it seems perfect

  So what I believe went wrong for large screens is your media-query where you give all the .list a display of flex , however for small screens you did not give them any display property at all , that's why hidden works on small screen. A quick fix would be something like list.style.display = "none"; instead of list.hidden = true;

  Hope this helps 🤞

  Happy Coding 😇 and Keep Contributing these awesome solutions 🚀

  1

  ---

  

  Olaleye Blessing•355

  @Olaleye-BlessingPosted almost 4 years ago

  @abhik-b Thanks for the observation. I'd change it to display: none

  1