Skip to content
Submitted over 2 years ago

I used HTML, CSS and Javascript to complete this challenge

offiong ekpenyong•40
@Offiongwhilley
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Interactive rating component
  • HTML
  • CSS
  • JS
1newbie

Design comparison

SolutionDesign

Solution retrospective

At first, I struggled with my javascript code. I was not sure which function to define within which. After many attempts, my logic worked.

I would like to know whether there are other ways which I can restructure my javascript code so that it's shorter and simpler to read.

Community feedback

  • Grace•31,230
    @grace-snowPosted over 2 years ago

    Hi

    I notice issues with the html that need fixing on this

    • Indent your code consistently. Your code editor can even do this formatting automatically for you
    • this design shows a form with radio inputs. It should not be a div with a load of buttons inside (essential)
    • use landmark elements to wrap page content. This should be a main element for the content and a footer element for the frontend mentor attribution
    • remove all the br tags from the paragraphs. Let the max width of the container determine where lines break, never try to control it like that
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord