Design comparison
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Ordy, congratulations for your new solution!
You've done a great work doing this project, I know how hard its to create this grid layout. There are some things you can change in order to improve. For example, the font its not correct imported.When you download the project files there’s a file called
style-guide.md
where you can find information such ashsl color codes
and thefont-size
for the headings.Here's the correct import for this font:
@import url(https://fonts.googleapis.com/css2?family=Barlow+Semi+Condensed:wght@400;600&display=swap);
To make the profile image scale correctly and dont distort use
display: block
max-width: 35px
max-height: 36px
Improve the html semantics wrapping the main div with
<main>
or section, about the cards you can replace the<div>
that wraps each card with<article>
and the paragraph with the quoting text with the property tag<blockquote>
this way you'll wrap each block of element with the best tag in this situation.👋 I hope this helps you and happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord