Design comparison
Solution retrospective
Hey guys, this is my first design and i will love a feedback on of what was not written well in the code or needed be adjust in the design.
Community feedback
- @En-JenPosted over 4 years ago
Hey there, nice job for your first project!
-
One thing I'd suggest is making sure to always add some text for alt="" in your html for images. The alt attribute is required so that the alternative text will display if the image can't be displayed or if the user is using a screen reader.
-
Another thing is that it is always best practice not to use inline CSS in your html because it's very difficult to override if you need to later on down the road. Instead of using inline CSS, you can simply give that element a class, and then use that class name as a selector in your style.css file.
-
Instead of using the <b> tag in your html to make certain elements bold, I would suggest just giving those elements a higher font-weight value in your CSS. I would set the font-weight for the body to 400 and then the elements that you want bolder to 700. To do that, when you copy and paste the <link> element for the Google font into your html, make sure to select all the font weights you'll need in your project (in this case, 400 and 700).
-
Don't forget to make the mobile background appear on smaller screen sizes.
-
Add some padding on the right and left sides of the lower box at smaller screen sizes so that the bar that shows how much storage space is being used doesn't span the entire width of the box.
This is a bit of a challenging project for a beginner, so really good work. Keep up the great work! - Jen
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord