Hi, this is missing some important foundational practices
- all content should be contained within landmarks. This needs a main to wrap the component and a footer for the attribution.
- this has one heading and one paragraph. All content can't be headings.
- choosing the correct heading level is important too. This is not a full Web page, just a single card component. It would sit within a full Web page, possibly alongside other similar cards. So you know that heading is not the page title and cannot be a h1.
- the image is really important content here. That means it needs alt text. Remember alt text is readable content not code like a class name. Read the post in the resources channel on discord about how to write good alt text.
- font size must never ever be in px
- the max width on the component must be in rem so the layout works for all users, including those of us with a different default text size.
- try to get the sizing much closer to the design
Marked as helpful
1
usema08• 60
@usema08
Posted
@grace-snow thank you for your feedback. I will work on improving myself.
0
