@vanzasetia
Posted
👋Hi Marko!
👍 Good job on completing your first challenge on Frontend Mentor. I hope that you learn a lot when you built this project 😉. To be honest, the result still needs a lot of improvement.
So, I will give you some feedback:
- It's great that you wrapped all contents inside the landmark (
main
, andfooter
tag). 👍 Well done on this one. - In this case the illustration and the music icon is decorative images. Remember, all decorative images, you should leave the
alt=""
empty and addaria-hidden="true"
orrole="presentation"
. That way the screen reader will ignore those images. - You don't need to wrap the Change with
p
tag, an anchor tag itself is enough. - Heading tags must go in order. You need to use
h2
before you can useh3
. - The Proceed Payment and Cancel Order should be a button or anchor link (choose one).
- You should not defined the
width
on themain
element. It should be amax-width
so it doesn't become so large on every screen size. - Use
rem
or sometimesem
, don't usepx
. Pixel unit will not allow the user to control the size of your page.
Tip on writing HTML is that, imagine that you write it as a document (without any CSS), that way you can make a better decision on using the correct HTML tags.
That's it! Hopefully this is helpful and good luck with your coding journey!
Marked as helpful
@Elioskas
Posted
@vanzasetia Thank you very much for such a detailed feedback. It's very helpful. I realize that I have overlooked few things in the code, so thank you again for taking the time to look over it. I wish you all the best. :)