I used HTML and CSS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 3 years ago

  Nice work on this challenge, Boris, and congrats on completing your first challenge! 🎉

  I'd recommend moving your link tag for the style.css below the Bootstrap links in the head of your HTML. At the moment, the resets from the reboot.scss file, like the font-family are overwriting your styles. That's why the fonts look different from the design. Always be sure to load in your custom CSS file last, otherwise, these specificity issues can happen.

  Also, the attribution text overlaps on mobile due to the position: absolute; declaration. I'd recommend reworking that to get rid of the absolute positioning.

  Have you ever tried using min-width media queries instead of max-width? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain. It might be worth giving it a go on future projects.

  I hope those pointers help! Keep it up and let me know if you have any questions 🙂

  Marked as helpful

  0