I Used Grid and Flexbox

Community feedback

• 

  P

  Jeremiah Lateef•160

  @jeremiahlateefPosted over 2 years ago

  Hello Karem, always build for the mobile screen before you build the desktop screen. Most users will use a phone to check your site rather than a desktop or a laptop. You did well for the bigger screen but the smaller screen does not display all the features properly. Also, learn what sematic tags means and how to properly apply it to the HTML file.

  Marked as helpful

  0

  ---

  

  Karem Sherif•90

  @KaremSherifPosted over 2 years ago

  @Jerryl-597 ok bro thanks for supporting me I will take by your ideas

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Karem, great work on this challenge! 😉

  Here are a few tips for improve your code:

  • add margin-inline: auto to max-width class to center the page content in the large screen
  • use header tag for wrap the navbar and for improve the Accessibility instead of using section tag
  • add main tag and wrap the content of page and section for improve the Accessibility
  • don't forget the footer in the bottom of page
  • add descriptive text in the alt attribute of the images
  • use button istead a tag for the buttons
  • instead of using px use relative units of measurement like rem -> read here

  Overall you did well 😁 Hope this help!

  Marked as helpful

  0

  ---

  

  Karem Sherif•90

  @KaremSherifPosted over 2 years ago

  @denielden thanks bro those points give me good ideas I'm grateful to you thanks for your time

  1