I used google font for the fonts and no other tools used.

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
  • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
  • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="container"> element with the proper semantic element <main> along with <div class="attribution"> into a <footer> element in your index.html file to improve accessibility and organization of your page

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Ahbideen Yusuf•160

  @bravonoPosted over 1 year ago

  @0xAbdulKhalid Thank you for that useful tips. I've learned HTML and CSS since February last year and I have not been practicing since then. Lucky for me I found Frontend-Mentor and this is my first project since then.

  0
• 

  Eni•180

  @EnidaShehuPosted over 1 year ago

  Good job overall :)

  To improve the code, you can consider the following suggestions:

  1. Remove duplicated CSS properties: The font-family property is specified twice in the body style. You can remove the second declaration to avoid redundancy.

  2. Add comments for clarity: Consider adding comments to the CSS code to provide clear explanations for each section or rule. This can be helpful for both yourself and other developers who may work on the code in the future.

  Marked as helpful

  1

  ---

  

  Ahbideen Yusuf•160

  @bravonoPosted over 1 year ago

  @EnidaShehu Yeah yeah, thank you for pointing that out. I completely missed it. I will start adding comments from now on. Thank you again

  0