@VCarames
Posted
Hey @shane86920915, some suggestions to improve you code:
- Your card isn't responsive at all, your going to want to back and rewrite a lot of your CSS Code to make it so.
Heres a link that can should exactly how to do that:
- Your use of the Section Element is incorrect. Its meant to wrap Blocks of content. So your layout should look something like this:
<body>
<main>
<section>
<div>Text Content</div>
<picture></picture>
</section>
</main>
</body>
-
Never use
widthwhen building content that you want to be Responsive. Instead usemax-width. -
The Attribution needs to be wrapped in a Footer Element.; It's the end of you content.
-
To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
More Info:
https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9
- To make it easier to deal with CSS , have more control over your content, and ensure that your content will look the same regardless of browser used I suggest using CSS Resets.
Your CSS Reset is extremely bare. You want to add more to it.
Here are few CSS Resets that you can look at and use to create your own CSS Reset or just copy and paste one that already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
Happy Coding!
Marked as helpful
@shane86920915
Posted
@vcarames Thank you, your feedback is much appreciated. One of my problems was controlling the text; I couldn't keep it inside the container. I will try and apply what you and Lucas said in my next project.
