Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

I used font converter to convert the font ttf to woff2 .

shreya792 10

@shreya792

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is welcome thankyou in advance

Community feedback

@dimar-hanung

Posted

Hi.. 👋, Congratulations on completing the challenge 🎉 .

I have some interest and feedback with your code

That i like:

  1. I appreciate the similarity of your results with the design, a bit different in font scale but still good
  2. html is pretty good, not too nested and with combination semantic HTML👍
  3. Responsive until galaxy fold screen size 👌

My Feedback:

  • Maybe you can use tools like prettier to format your code to be more beautiful ( TIP: set prettier configuration to format on save, make it easier )
  • Give html class naming is recomended, this can prevent style conflict in future, but in this case it is not necessary, so it's ok 🙌
  • You can seperate file by folder to be more structured, for example:
public/
├─ images/
│  ├─ qr-code-image.png
├─ styles/
│  ├─ main.css
├─ favicon.png
index.html

overall is good, nice solution, hope it useful 🙌

0
Bader Idris 2,900

@Bader-Idris

Posted

You can set the container in the middle of the screen whatever user changes it when you add these properties to it in CSS:

.container {
  position: absolute;
  top:50%;
  left: 50%;
  transform: translate(-50%, -50%);
}

the new feature is transform, it has many lovely properties you can discover, I personally love it. Hope it's useful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord