Skip to content
Submitted over 2 years ago

I used Flexbox for responsiveness and styling was done with SASS

Dennis Owieā€¢30
@IrezD
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi! Please I would like to get feedback on my codes if it is clean enough.

I am using SASS so the structure of how my CSS is compiled won't be same as when I style directly with Vanilla CSS but I am really trying hard to keep my codes clean. Still, I am not sure how much I should be worried about that, would be nice to get feedback. Thank you!

Community feedback

  • Shashree Samuelā€¢9,260
    @shashreesamuelPosted over 2 years ago

    Hey good job completing this challenge

    Keep up the good work

    Your solution looks great except you misspelled the world "luxury".

    In terms of your accessibility issues simply wrap all your content between main tags

    I hope this helps

    Cheers Happy coding šŸ‘

    Marked as helpful
    0
    Dennis Owieā€¢30
    @IrezDPosted over 2 years ago

    @TheCoderGuru

    Hahaha. Thanks! I just realised the misspelling.

    And thank you for clarifying why I had the accessibility issue.

    Really Appreciate your feedback a lot:) Very helpful!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord